Skip to content

Fix linting/compilation violation#37505

Merged
damccorm merged 2 commits intomasterfrom
users/damccorm/fixLint
Feb 4, 2026
Merged

Fix linting/compilation violation#37505
damccorm merged 2 commits intomasterfrom
users/damccorm/fixLint

Conversation

@damccorm
Copy link
Contributor

@damccorm damccorm commented Feb 4, 2026 •
edited
Loading

Context - https://github.com/apache/beam/pull/37009/changes#r2765834617 had some breakages and this fixes the problem

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 4, 2026

Summary of Changes

Hello @damccorm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a compilation violation by updating a test case in WindmillTagEncodingV2Test.java. The change ensures that the test correctly invokes the TimerData.of method, which now requires an additional CausedByDrain parameter, thereby resolving the build issue and maintaining code consistency.

Highlights

  • Test Case Update: Modified WindmillTagEncodingV2Test.java to align with a recent change in the TimerData.of constructor, specifically adding the TimerData.CausedByDrain.NORMAL parameter.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/windmill/state/WindmillTagEncodingV2Test.java
    • Updated the TimerData.of method call to include the TimerData.CausedByDrain.NORMAL argument, resolving a compilation error.
Activity
  • This change is a direct follow-up to a discussion or previous change, as indicated by the context link to https://github.com/apache/beam/pull/37009/changes#r2765834617.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

This was referenced Feb 4, 2026
Merged
Closed
damccorm
damccorm commented Feb 4, 2026
View reviewed changes
...t/java/org/apache/beam/runners/dataflow/worker/windmill/state/WindmillTagEncodingV2Test.java
new Instant(123),
new Instant(456),
timeDomain,
TimerData.CausedByDrain.NORMAL);
Copy link
Contributor Author

@damccorm damccorm Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context: https://github.com/apache/beam/pull/37009/changes#r2765834617 changed the API, and this reverts us back to the behavior before that was merged (this test doesn't need any updated functionality)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

Assigning reviewers:

R: @shunping added as fallback since no labels match configuration

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm damccorm merged commit c1ecbb9 into master Feb 4, 2026
15 checks passed
@damccorm damccorm deleted the users/damccorm/fixLint branch February 4, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrmccluskey jrmccluskey jrmccluskey approved these changes

Assignees

No one assigned

Labels

dataflow Next Action: Reviewers runners

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@damccorm @jrmccluskey